then-able dispatches to AliasedActions #309
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @PaulSzymanski |
In the main process dispatches to thunk actions could be awaited. However this was not possible for aliased thunk actions. With this commit we can await dispatches to aliased thunk actions in the renderer.
PaulSzymanski
force-pushed
the
promise-dispatch
branch
from
c348022
to
9bbfe27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks, I want to await dispatches in the renderer as I am able to in the main process.
I replaced the IPC send with an invoke-able IPC.
This works like a charm for me :)
I would love to hear your thoughts on this!
I did not adjust the type definitions yet.